please add IBM brightness fix to upstream fdi file
David Zeuthen
david at fubar.dk
Sat Feb 17 15:44:31 PST 2007
On Thu, 2007-02-15 at 20:28 +0000, Richard Hughes wrote:
> On Thu, 2007-02-15 at 15:21 -0500, David Zeuthen wrote:
> > On Thu, 2007-02-15 at 20:07 +0000, Richard Hughes wrote:
> > > On Thu, 2007-02-15 at 14:48 -0500, David Zeuthen wrote:
> > > >
> > > > I'm unsure what Thinkpads these are? Does anyone know? Also, Richard,
> > > > what's the risk of setting brightness_in_hardware to TRUE assuming the
> > > > laptop don't do brightness in hardware?
> > >
> > > No harm, if this is set then g-p-m just reads the new brightness from
> > > hal rather than try to set the brightness.
> > >
> > > Worst case scenario is that the brightness button that used to work stop
> > > working.
> >
> > So it seems like the right thing to apply this patch yes?
>
> Hmm. I was talking to Oliver a couple of days ago. He was going to put
> it in the ubuntu flight release and see if there are any reported
> regressions. Up to you tho, we can always revert it if there are
> problems.
I'd say we just put it in. I have a T41 that needs this treatment too
IIRC.
David
More information about the hal
mailing list