[PATCH] fix sonypi/spicctrl set/get brightness support

David Zeuthen david at fubar.dk
Wed Feb 21 09:40:01 PST 2007


On Wed, 2007-02-21 at 17:05 +0000, Bastien Nocera wrote:
> On Tue, 2007-02-20 at 19:27 -0500, David Zeuthen wrote:
> > On Wed, 2007-02-21 at 00:20 +0000, Bastien Nocera wrote:
> > > Actually, the rest of the killswitch implementation (for WWAN, or Wifi)
> > > would be pretty much the same, so I'd rather change the interface name
> > > to KillSwitch.
> > 
> > I guess that's fine with me. I'm a bit scared of proposing such generic
> > interface without having looked at the implementations in detail... OTOH
> > if we can kill two or three birds with one rock... then. I think it's a
> > good idea.
> 
> Patch attached. Hopefully, it'll apply properly this time. Also include
> the configure changes so that sonypic will be disabled if no
> linux/sonypi.h header is found.

I've committed this, thanks! As requested on IRC it would be good with a
file doc/howto/bluetooth_killswitch_support.txt that explains how to add
this for other make/models of laptops. For example, the IBM's and the
Dell's.

     David




More information about the hal mailing list