[PATCH] fix sonypi/spicctrl set/get brightness support

Bastien Nocera hadess at hadess.net
Wed Feb 21 10:33:15 PST 2007


On Wed, 2007-02-21 at 19:24 +0100, Danny Kukawka wrote:
> On Wednesday 21 February 2007 18:40, David Zeuthen wrote:
> > I've committed this, thanks! As requested on IRC it would be good with a
> > file doc/howto/bluetooth_killswitch_support.txt that explains how to add
> > this for other make/models of laptops. For example, the IBM's and the
> > Dell's.
> 
> Unfortunately it doesn't build because of g_ascii_strtoll() which was 
> introduced with glib 2.12. Is this really needed (only because of one 
> function) or could we use an other function? Otherwise the attached patch is 
> needed, but HAL would no longer build on machines with glib < 2.12.

g_ascii_strtoull, or even strtol would probably do fine as well, as long
as it doesn't munge the envvar data.

Which way do you prefer?

-- 
Bastien Nocera <hadess at hadess.net> 



More information about the hal mailing list