[PATCH] fix sonypi/spicctrl set/get brightness support
David Zeuthen
david at fubar.dk
Wed Feb 21 11:06:00 PST 2007
On Wed, 2007-02-21 at 18:33 +0000, Bastien Nocera wrote:
> > Unfortunately it doesn't build because of g_ascii_strtoll() which was
> > introduced with glib 2.12. Is this really needed (only because of one
> > function) or could we use an other function? Otherwise the attached patch is
> > needed, but HAL would no longer build on machines with glib < 2.12.
Sharp eyes, Danny!
> g_ascii_strtoull, or even strtol would probably do fine as well, as long
> as it doesn't munge the envvar data.
I've now changed this to g_ascii_strtoull() which is available since
glib 2.2. We shouldn't bump requirements unless absolutely necessary.
David
More information about the hal
mailing list