[PATCH] add support for copy_property for strlist properties

David Zeuthen david at fubar.dk
Wed Feb 28 10:17:27 PST 2007


On Sat, 2007-02-24 at 17:35 +0100, Danny Kukawka wrote:
> Hi,
> 
> this patch adds support of the copy_property FDI directive for stringlist 
> properties. This would allow to copy/overwrite a stringlist with values from 
> e.g. an other device.

Looks good; one thing however

> +               /* don't bother setting the same value TODO: CHECK IF THIS WORK */
> +               if (hal_property_get_strlist (prop) == value)
> +                       return TRUE;

This is not going to work; you have to check all elements with strcmp().

With such a change this is good to commit. Thanks.

     David




More information about the hal mailing list