[PATCH] add addon for OMAP gpio

Guillem Jover guillem.jover at nokia.com
Wed Feb 28 11:57:30 PST 2007


On Wed, 2007-02-28 at 13:37:38 -0500, ext David Zeuthen wrote:
> On Tue, 2007-02-27 at 20:56 +0000, Rob Taylor wrote:
> > Exposes OMAP gpio switches as HAL buttons.
>
> HAL knows about switches from the Linux input layer too. We map
>
>  SW_LID              -> "lid"
>  SW_TABLET_MODE      -> "tablet_mode"
>  SW_HEADPHONE_INSERT -> "headphone_insert"
>
> and your patch introduces these new candidates for "button.type"
> 
>  "activity", "connection", "cover"
> 
> Perhaps "activity" and "connection" can be made a bit more abstract
> and/or well-defined?

'connection' could be changed to 'headphone_insert'.
'activity' is used right now by the camera switches, for rotation and
when it's popped out.

> Perhaps "cover" is really "lid"?

'cover' is used by the battery cover, it seems appropriate to me. Also
I've to finish a patch to add buttons for the mmc covers which we have
on the N800, which could use the same type.

regards,
guillem


More information about the hal mailing list