[PATCH] fix hald crash after attempt to unmount ignored volume.

[Danny Kukawka]

On Friday 05 January 2007 09:20, Andrey Borzenkov wrote:
> On Thursday 04 January 2007 22:32, Danny Kukawka wrote:
[...]
> > IMO this lines doesn't crash HAL. I can't see how this can crash the
> > daemon atm.
>
> LIBHAL_FREE_DBUS_ERROR writes to stderr which apparently confuses libdbus.
> Full trace is
>
> 19:00:32.166 [I] hald_dbus.c:2972: Refreshing mount state
> for
> /org/freedesktop/Hal/devices/volume_uuid_f340078d_4758_4d33_a4ac_a148c95c75
>58 since Unmount() completed
> 19:00:32.166 [I] hald_dbus.c:3027: failed with 'hal-storage-shared.c 285 :
> INFO: called LIBHAL_FREE_DBUS_ERROR but dbusError was not
> set.' 'org.freedesktop.Hal.Device.Volume.PermissionDenied'
> process 4822: arguments to dbus_message_new_error() were incorrect,
> assertion "_dbus_check_is_valid_error_name (error_name)" failed in file
> dbus-message.c line 1207.

Interesting. How did you compile D-Bus (which options) and which version is 
this. I never saw such a error before. 

We should investigate the real reason for this error. IMO the current fix is 
only cosmetic.

> There could be other places like this.
>
> > Btw. I attached a more clean patch to differ between the case where the
> > call of libhal_device_get_property_bool() return correct true and the
> > case where the call really fail and the error is set (and freed then).
>
> OK I was unsure what libhal_device_get_property_bool returns in case of
> error.

It returns always false if there happen any kind of error.

> > > Patch attached as kmail tends to mangle lines :(
> >
> > Please send the patch via KMAil with option "Suggest automatic display".
> > ;-)
>
> Can I convince Kmail to do it automatically for text attachments?

IIRC this is not possible (Or I could not find the place to config) with 
current KMail version, but IIRC this worked in older versions. I take a look 
at this issue ;-)

Danny