[PATCH][RFC] g_dir_open->opendir

David Zeuthen david at fubar.dk
Mon Jan 8 10:16:13 PST 2007


On Thu, 2006-12-14 at 23:20 +0300, Sergey Lapin wrote:
> Hi!
> As I see through the code, near line 660 of hald/linux/blockdev.c, if I 
> set break point on a line with g_dir_open, on n770 device and probably 
> others, you'll se memory consumption increase by 100K. So I think 
> replacing this call with POSIX readdir would be useful.
> 
> Please see attached patch. It will benefit at least when you use kernel 
> 2.6.16 on arm (nokia 770 is an example; you don't have loopX/slaves in 
> sysfs).

Committed, but please pay attention to compiler warnings in the future;
I committed a patch on top of it to remove two unused variables. Thanks!

     David




More information about the hal mailing list