[PATCH] fix hald crash after attempt to unmount ignored volume.

[Andrey Borzenkov]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Saturday 06 January 2007 15:37, Danny Kukawka wrote:
> Hm, only to be sure that I understand the problem correct: A programm that
> started by HAL and which use D-Bus can't write to stderr without write
> first a valid service name like 'org.freedesktop.Hal.Device*' for the D-Bus
> error name? Sorry, but if this is correct, this is really strange and
> annoying for tools which write debug messages as many of the code in the
> tools directory.
>

Well I just had yet another case of the same problem. 

12:46:55.531 [I] hald_dbus.c:2964: No more methods in queue
12:46:55.531 [I] hald_dbus.c:3027: failed with '/etc/pm/hooks/99printk~: line 
11: /etc/sysconfig/suspend: No such file or 
directory' '/etc/pm/hooks/99printk~: line 11: /etc/sysconfig/suspend: No such 
file or directory'
process 31132: arguments to dbus_message_new_error() were incorrect, 
assertion "_dbus_check_is_valid_error_name (error_name)" failed in file 
dbus-message.c line 1207.
This is normally a bug in some application using the D-Bus library.
  /lib/libdbus-1.so.3 [0xb7ead0b9]
  /lib/libdbus-1.so.3 [0xb7eac454]
... etc

so we have a perfectly valid case of failed callback which gets misinterpreted 
by HAL again.

Of course, it is possible to "fix" it by turning off assertions ... but is it 
really a fix?

regards 

- -andrey
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)

iD8DBQFFsem8R6LMutpd94wRAmXvAKCg5v/UQ+WxBcWXt+HeOAgyocS+sACgvBtM
f+Qu0JD+teuMK3ztupAYuIw=
=qLC+
-----END PGP SIGNATURE-----