[PATCH] Make hotplugging non-recursive.

Rob Taylor rob.taylor at codethink.co.uk
Wed Jan 31 10:36:14 PST 2007


Richard Hughes wrote:
> On Wed, 2007-01-31 at 16:03 +0000, Rob Taylor wrote:
>> Ok to commit?
> 
> I get:
> 
> patching file hald/hald_runner.c
> patching file hald/hald_runner.h
> Hunk #1 FAILED at 83.
> 1 out of 1 hunk FAILED -- saving rejects to file hald/hald_runner.h.rej
> patching file hald/linux/blockdev.c
> Hunk #1 FAILED at 315.
> Hunk #2 FAILED at 1302.
> 2 out of 2 hunks FAILED -- saving rejects to file
> hald/linux/blockdev.c.rej
> patching file hald/linux/hotplug.c
> Hunk #1 FAILED at 67.
> Hunk #2 FAILED at 75.
>

Well, that's confusing as its the output of git-format-patch from my
branch against master, and my master is up to date, *and* I've tested
the patches apply to master. Is your master up to date?

> Can you please attach patches as attachments - evolution does bad things
> with patches for me.

Ok, i had a vague memory of David saying that patches should be inline,
but I'll happily do git-format-patch --attach in future ;)

Thanks,
Rob




More information about the hal mailing list