[patch] Create a new device_pm.{c|h} for internal use

Richard Hughes hughsient at gmail.com
Tue Jul 3 11:02:06 PDT 2007


On Tue, 2007-07-03 at 19:56 +0200, Danny Kukawka wrote:
> 
> Uh ... looks not that good to me. Why do you use in pmu.c 
> device_pm_remove_optional_props() to remove 6 properties by try to
> remove 35.
> Looks really inefficient, you should only remove the keys you really
> have used. 

Disagree. Not removing a missing property is very cheap, and removing a
battery is something that is done once in a blue moon. Abstracting out
the common routine easily outweighs the few us slowdown.

Plus, pmu.c should soon be disabled, as pmu battery state is now
abstracted in power_supply device class. I'll test this later.

Richard.




More information about the hal mailing list