[PATCH 1/2] Add support for ipw killswitch to hal

Adel Gadllah adel.gadllah at gmail.com
Tue Jul 10 07:55:17 PDT 2007


David Zeuthen wrote:
> On Tue, 2007-07-03 at 11:17 +0200, Adel Gadllah wrote:
>   
>>> How about excluding Sony Vaio as well? (maybe Bastien knows?)
>>>   
>>>       
>
> Well, doh, I wasn't thinking earlier; we only do Bluetooth killswitch
> support for Sony laptops. So that check is unnecessary at this point.
>
>   
ok
>> ok, done.
>> also fixed the first patch to use hal-ipw-killswitch-linux instead of 
>> ipwWirelessCtl in the errormessage.
>> both are attached.
>>     
>
> I've committed your patches with the following changes
>
> http://gitweb.freedesktop.org/?p=hal.git;a=commitdiff;h=988aed5de7dc83f0e715f67ff6840d2e79be6b57;hp=98deefad69138777fc8236048913918b587469c5
>
> http://gitweb.freedesktop.org/?p=hal-info.git;a=commitdiff;h=f0f015d4552cbd2aa2c85a7bd7cb06b95c0eaf73
> http://gitweb.freedesktop.org/?p=hal-info.git;a=commitdiff;h=6e4cd71722d7ca190157370646b4944cd6fc90fe
> http://gitweb.freedesktop.org/?p=hal-info.git;a=commitdiff;h=e2a01e0fd63a2ce67f6a4c954f896805e1de2f93
> http://gitweb.freedesktop.org/?p=hal-info.git;a=commitdiff;h=58b9a7041771f64bff6dde386cd2364205bd65d4
>
> As you can see I've added a copyright + license header; I presume you're
> fine with using the standard GPL and AFL licenses. Otherwise give me a
> shout. 
should be fine.
> The coding style in the C code totally violates the rest of the
> code but since it's a simple and hopefully temporary piece of code I
> didn't touch it.
>
>   
ok, is there any coding style doc for hal like for the linxu kernel or 
should I just look at the hal code?
> If you can test HEAD of hal-info and hal to see if this works it would
> be appreciated. Thanks.
>   
ok, will do it.




More information about the hal mailing list