[patch] Fix the SetPowerSave() method parameter type

David Zeuthen david at fubar.dk
Tue Jul 17 08:24:45 PDT 2007


On Tue, 2007-07-17 at 14:23 +0100, Richard Hughes wrote:
> David,
> 
> When we were fixing the uint/int retval problem a few months ago the
> SetPowerSave method got changed from u SetPowerSave (b) to u
> SetPowerSave (i). The hal-system-power-set-power-save script assumes the
> bool rather than the signed int. This gives the error in
> gnome-power-manager:
> 
> ** WARNING **: ERROR:  
>  usage : hal-set-property --udi <udi> --key <key> aborting...
> 
> This also causes an abort if --g-fatal-warnings is used to run g-p-m.
> 
> I assume you just changed the b to an i as an oversight, in which case
> the attached patch fixes the problem. If you do want to keep the script
> input parameter as an int we'll have to fix up the shell we are using.
> 
> Comments?

Yeah, don't know why that got changed. Please commit. Thanks.

      David




More information about the hal mailing list