hald-addon-acpi dying

Hannu Lyytinen hlyytine at cs.uku.fi
Wed Jul 18 04:49:31 PDT 2007


Hi,

hald-addon-acpi died everytime I pressed any Thinkpad extra buttons on
this T60p. Seems like there's a problem in
hald/linux/addons/addon-acpi.c. In main_loop() dbus_error_free() might
be executed without having called dbus_error_init() first. A quick
(perhaps not elegant) patch is attached to solve this problem.
-------------- next part --------------
diff -upr a/hald/linux/addons/addon-acpi.c b/hald/linux/addons/addon-acpi.c
--- a/hald/linux/addons/addon-acpi.c	2007-07-18 17:23:09.000000000 +0300
+++ b/hald/linux/addons/addon-acpi.c	2007-07-18 17:31:04.000000000 +0300
@@ -182,6 +182,7 @@ main_loop (LibHalContext *ctx, FILE *eve
 	while (fgets (event, sizeof event, eventfp))
 	{
 		HAL_DEBUG (("event is '%s'", event));
+		dbus_error_init (&error);
 
 		if (sscanf (event, "%s %s %x %x", acpi_path, acpi_name, &acpi_num1, &acpi_num2) == 4) {
 			char udi[256];


More information about the hal mailing list