[PATCH] GetBrightness method has to return _unsigned_ int

[Danny Kukawka]

On Freitag, 1. Juni 2007, David Zeuthen wrote:
> The spec says (in it's own way) we return an INT32
>
> http://people.freedesktop.org/~david/hal-spec/hal-spec.html#device-properti
>es-laptop-panel
>
> and all methods implemented via spawning a helper _always_ return INT32
> (there's a TODO item for 0.5.10 about returning other types)
>
> http://people.freedesktop.org/~david/hal-spec/hal-spec.html#device-properti
>es-info-method-calls
>
> So it's like this
>
>  - applications such as g-p-m, kpowersave should expect INT32
>
>  - Introspection XML returned by HAL needs to say it's INT32
>
>  - HAL should return INT32 over the wire; except for method calls
>    using spawned helpers. The culprit is in hald_exec_method_cb()
>    in hald/hald_dbus.c. I've committed this patch

> I wonder what will break from this bugfix...

KPowersave, g-p-m (AFAIK), powersave (new version) and maybe other using the 
interface, but I think also other stuff will fail as e.g. call suspend or may 
mount/umount would break. 

This is IMO really problem and would cause many problems. I think we have to 
document _and_ expose/announce this also to the KDE/GNOME guys.

Danny