[PATCH] GetBrightness method has to return _unsigned_ int

Danny Kukawka danny.kukawka at web.de
Mon Jun 4 01:53:19 PDT 2007


On Montag, 4. Juni 2007, David Zeuthen wrote:
> On Sat, 2007-06-02 at 10:18 +0100, Richard Hughes wrote:
> > > This is IMO really problem and would cause many problems. I think we
> > > have to document _and_ expose/announce this also to the KDE/GNOME
> > > guys.
> >
> > Yes, you've fixed the bug but broken nearly all users of this.
>
> Yeah, I was afraid that was going to happen. I'm thinking the right
> thing is probably to change everything to return UINT32 rather than
> INT32. Thoughts?

I have no problem with the change to INT32, this make us more flexible and 
would fit the actual SPEC. I say only we have to announce that this now work 
as the spec say. We have to fix/change this anyway sooner or later to allow 
more flexibility.

Danny


More information about the hal mailing list