[patch] add keymap data to make random laptop vendor keys work

Daniel Stone daniel.stone at nokia.com
Mon Jun 4 06:51:05 PDT 2007


On Mon, Jun 04, 2007 at 02:24:41PM +0100, ext Richard Hughes wrote:
> On Mon, 2007-06-04 at 15:53 +0300, Daniel Stone wrote:
> > > Maybe we should just match the hald-setup-keymap against "AT
> > Translated
> > > Set 2 keyboard" and "ThinkPad Extra Buttons".
> > 
> > Just against ThinkPad Extra Buttons, no?  If you remap to something
> > sensible, then you can have a generic remapping for atkbd, and
> > everything using evdev just works anyway.
> > 
> > > I think this is the best way, and we can avoid poking around in
> > sysfs
> > > completely.
> > 
> > Indeed. 
> 
> What about the attached? (untested)

The input side of things looks fine to me.

> +	dbus_error_init (&error);
> +	dbus_error_init (&error);
> +	dbus_error_init (&error);
> +	dbus_error_init (&error);

Is this not a bit excessive? :)

Cheers,
Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.freedesktop.org/archives/hal/attachments/20070604/29fa0f68/attachment.pgp 


More information about the hal mailing list