[patch] add keymap data to make random laptop vendor keys work
Lennart Poettering
mzuny at 0pointer.de
Mon Jun 4 08:20:41 PDT 2007
On Mon, 04.06.07 14:24, Richard Hughes (hughsient at gmail.com) wrote:
> + } while (keymap_list[i++] != NULL);
> +
> + libhal_free_string_array (keymap_list);
> +
> + /* we do not have to poll anything, so exit */
> + return 0;
Another quick note: you're missing a lot of destruction code
here. I.e. close()ing the evdev fd, shutting down the dbus connection
and suchlike.
Probably doesn't matter, but might be worth to fix to make the valgrind
output more useful.
Lennart
--
Lennart Poettering Red Hat, Inc.
lennart [at] poettering [dot] net ICQ# 11060553
http://0pointer.net/lennart/ GnuPG 0x1A015CC4
More information about the hal
mailing list