[PATCH] LG Fusic Phone/USB music player

Jeff Mitchell kde-dev at emailgoeshere.com
Fri Jun 8 20:40:28 PDT 2007


On Friday 08 June 2007, Steven Walter wrote:
> On Fri, Jun 08, 2007 at 09:21:58PM -0400, Jeff Mitchell wrote:
> > Steven--
> >
> > Are you sure you attached the updated patch?  Looks exactly like the
> > first one, here...
> >
> > Also, look at the <addset> directive (and use it with any strlist
> > properties  :-) ).  It's new in 0.5.10 and it ensures that you don't
> > double-append values to a strlist (for instance, if some userspace
> > library also contains an entry for the phone).
> >
> > Sorry, don't mean to make this difficult for you...but as the one who
> > made the spec change, it's kind of defaulting to me to actually
> > (eventually) update all the entries currently in
> > 10-usb-music-players.fdi...not something I'm looking forward to.  It
> > doesn't help that davidz hasn't updated the spec on the official
> > site...heh.  :-)
>
> Whoops, my bad.  I did "git commit" without "git add."  Normally it
> would have given me a warning, but I had used "git reset --soft" to redo
> that commit.  Silly me.
>
> Hopefully the right thing is attached this time.

A few issues that I can see:

The correct key is portable_audio_player.access_method.protocols, not 
portable_audio_player.protocols.  portable_audio_player.access_method might 
be deprecated soon, but .protocols and .drivers will probably stay in the 
access_method namespace (if it doesn't I can update later).

However:  you have

<addset>blahblah</append>

Match the tags please :-)

--Jeff


More information about the hal mailing list