[PATCH] hal-info power management quirks for IBM T42

L. David Baron dbaron at dbaron.org
Wed Jun 13 11:23:30 PDT 2007


The attached patch adds a rule for the power management quirk
(s3_bios) needed to get my IBM T42 laptop (bought in December 2004)
to suspend.

I tested that suspend+resume works correctly with the s3_bios quirk:
 1. running X with the radeon driver
 2. running X with the proprietary ATI fglrx driver
 3. from tty1 (well, using pm-suspend --quirk-s3-bios rather than the
    quirk coming from hal)

I tested that not having the quirk breaks resume with both the
radeon and fglrx drivers (didn't try tty1).  I tested that also
having the s3_mode quirk breaks resume using the fglrx driver
(didn't try other cases).

This testing was all done on Fedora 7, although using an older X
server (from Fedora Core 6) that's needed for the fglrx driver.

I added the rule so that it matches both system.hardware.product and
system.hardware.version, although there's a good bit of
inconsistency in how the entries in 20-video-quirk-pm-ibm.fdi match,
so I'm not sure which is preferred.

It passes make check (although 10-usb-music-players.fdi currently
doesn't).

-David

-- 
L. David Baron                                <URL: http://dbaron.org/ >
           Technical Lead, Layout & CSS, Mozilla Corporation
-------------- next part --------------
diff --git a/fdi/information/10freedesktop/20-video-quirk-pm-ibm.fdi b/fdi/information/10freedesktop/20-video-quirk-pm-ibm.fdi
index f2cffde..89eeda5 100644
--- a/fdi/information/10freedesktop/20-video-quirk-pm-ibm.fdi
+++ b/fdi/information/10freedesktop/20-video-quirk-pm-ibm.fdi
@@ -42,6 +42,12 @@
         <merge key="power_management.quirk.s3_bios" type="bool">true</merge>
         <merge key="power_management.quirk.s3_mode" type="bool">true</merge>
       </match>
+      <!-- T42 -->
+      <match key="system.hardware.product" prefix="2378">
+        <match key="system.hardware.version" string="ThinkPad T42">
+          <merge key="power_management.quirk.s3_bios" type="bool">true</merge>
+        </match>
+      </match>
       <!-- T43 -->
       <match key="system.hardware.product" prefix="2668">
         <match key="system.hardware.version" string="ThinkPad T43">


More information about the hal mailing list