[PATCH] add addon for OMAP gpio

Rob Taylor rob.taylor at codethink.co.uk
Mon Mar 5 06:03:33 PST 2007


David Zeuthen wrote:
> On Wed, 2007-02-28 at 21:57 +0200, Guillem Jover wrote:
>>> Perhaps "activity" and "connection" can be made a bit more abstract
>>> and/or well-defined?
>> 'connection' could be changed to 'headphone_insert'.
> 
> Sounds good.

agreed, It'd also be good to look at what we want to expose from alsa in
terms of headphone insert events.

>> 'activity' is used right now by the camera switches, for rotation and
>> when it's popped out.
> 
> Interesting. Perhaps call it camera_activity or even {nokia|
> omap}.activity? I'm just afraid of future namespace collisions.

maybe camera.direction and camera.activity? though that doesn't quite
fit with the current definition of a camera :/

>>> Perhaps "cover" is really "lid"?
>> 'cover' is used by the battery cover, it seems appropriate to me. Also
>> I've to finish a patch to add buttons for the mmc covers which we have
>> on the N800, which could use the same type.
> 
> So what I'd like to see are namespaces a'la
> 
>  cover.battery
>  cover.mmc
> 
> and so forth so apps can easily make a distinction. How about that?

Those sound good to me.


Thanks,
Rob Taylor


More information about the hal mailing list