hal 0.5.9 rc1

Dan Nicholson dbn.lists at gmail.com
Mon Mar 5 14:23:25 PST 2007


On 3/4/07, David Zeuthen <david at fubar.dk> wrote:
>
> We probably shouldn't add more features at this point; need to focus on
> bug fixing so 0.5.9 will shine. Thanks in advance for that.

David, some of the scripts in tools use the bashism '==' in tests
while using /bin/sh as their interpreter. This isn't POSIX compliant
and will break on non-bash /bin/sh like for Ubuntu.

$ ls -l /bin/sh
lrwxrwxrwx 1 root root 4 2007-02-21 00:28 /bin/sh -> dash
$ /bin/sh -c '[ foo == bar ]'
[: 1: ==: unexpected operator

The attached patch against HEAD fixes all the instances I could find.

 tools/hal-system-power-hibernate      |    2 +-
 tools/hal-system-power-reboot         |    2 +-
 tools/hal-system-power-set-power-save |    2 +-
 tools/hal-system-power-shutdown       |    2 +-
 tools/hal-system-power-suspend        |    2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

--
Dan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: hal-posix-sh.patch
Type: text/x-diff
Size: 3168 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/hal/attachments/20070305/7945bd22/hal-posix-sh.bin


More information about the hal mailing list