info.icon in HAL

[Rodney Dawes]

On Mon, 2007-03-05 at 19:04 -0500, David Zeuthen wrote:
> On Mon, 2007-03-05 at 17:03 -0500, Rodney Dawes wrote:
> > One problem is that we haven't yet decided how to ship and install the
> > icons, so that users will actually get them. I don't believe that
> > Matthias has committed his patch to GTK+, to do the fallback method as
> > described in the Icon Naming Spec, to SVN yet. Once GTK+ handles that
> > fallback method by default, and we have all the base icons in the
> > gnome-icon-theme package, users will at least be able to get sanely
> > usable icons, if they don't have the specific icons.
> >
> > So, I'd be a little hesitant to say that we should straight out start
> > sticking these properties into the FDI files yet. We need to get the
> > icon theme falling back entirely correctly, and ensure that all the
> > base device icons are available, before we do.
> 
> So probably the GNOME VFS patch for 2.18 should test whether that icon
> exists and if it doesn't it should fall back to the old icon naming
> code? If we do this we can start populating info.icon_name right away.

Probably, yes. However, we're now in hard code freeze until the 2.18.0
release next week. The code currently does not seem to depend on GTK+
at all, so I'm a little reluctant to add the dependency on GtkIconTheme
to it. This is definitely one of those cases where I wish the actual
Icon Theme implementation was in glib, and GTK+ just had an object on
top of it to do the pixbuf loading and all that.

> I'd like to do that, also such that future versions of HAL that does
> this won't break GNOME 2.18...
> 
> > Right now, from the theme side, I'm still working out how exactly we
> > should ship the icons. We don't want to just shove them all into
> > gnome-icon-theme and have them always available, I think.
> 
> I think have the main icons e.g. media-flash but not necessarily
> media-flash-cf in g-i-t makes sense. Then avid users can always install
> extra icons to get the "flash".

Right. This is basically how it currently is. We have the generic
media-flash icon in gnome-icon-theme now. I am thinking about how we
can deal with distributing the "extra" icons now. This is especially
hard in the devices case, as we probably want to prefer the generic
icon in the current theme, over a more specific icon in an inherited
theme, to keep the style consistent.

-- dobey