[PATCH] add support for ACPI IBM hotkey events

Danny Kukawka danny.kukawka at web.de
Mon Mar 26 03:13:30 PDT 2007


On Freitag, 19. Januar 2007, Danny Kukawka wrote:
> On Friday 19 January 2007 04:35, Matthew Garrett wrote:
> > On Sun, Jan 14, 2007 at 07:10:08PM +0100, Danny Kukawka wrote:
> > > Since we already propagate these events for normal ACPI events via HAL
> > > (as we report the related buttons as devices) and also provide such
> > > events for Toshiba machines, I would see them also for IBM until this
> > > _all_ will go in the future through the input layer.
> >
> > I believe that this is queued for 2.6.21. There's no real point in
> > adding it in order to just remove it again, especially if it encourages
> > people to depend on these event names.
>
> Yes, but this is not there atm. What I would see as minimum that we get the
> sleep/s2disk(hibernate) events as we already have from normal ACPI events.
> I don't see why we should not emit signals for them.
>
> Btw. nobody needs to depend on this signals, and there is also no need that
> HAL should depend on kernel 2.6.21, where 2.6.20 is not release currently.

I checked this with 2.6.21rc5 and could not see that this now go trough the 
input layer. The events are not available in an other way than via ACPI 
(except sleep and power button), or do I miss something?

IMO we should apply the patch to 0.5.9 if there is nothing in 2.6.21.

Danny


More information about the hal mailing list