[patch] add keymap data to make random laptop vendor keys work

Richard Hughes hughsient at gmail.com
Fri May 4 09:38:40 PDT 2007


On Fri, 2007-05-04 at 18:13 +0200, Danny Kukawka wrote:
> On Freitag, 4. Mai 2007, Richard Hughes wrote:
> > Agree. See attached (untested) patch.
> 
> Please add a config option to disable/compile out the addon, because may not 
> every distribution/user want to use it. 

Sure, that's a valid point. I'll add that.

> Btw. I would prefer a solution to allow a GUI application to set the keycodes 
> as e.g. the KDE control center.

This is scancode to keycode mapping - the scancodes never get to X and
are not detected, hence we can't do this in the GUI.

> An other point: have this really to be an addon? The definition of addons is:
> "Addons are programs that run for the life time of the device object. ..."
> IMO because of this the code should go into a callout and into the tool 
> directory in the source tree of HAL instead into a addon.

Yes, I think you are right there. Let me play some more, and I'll send
an updated patch.

Thanks for the review.

Richard.




More information about the hal mailing list