[patch] add keymap data to make random laptop vendor keys work

David Zeuthen david at fubar.dk
Fri May 4 13:27:40 PDT 2007


On Fri, 2007-05-04 at 18:48 +0100, Richard Hughes wrote:
> On Fri, 2007-05-04 at 17:39 +0100, Richard Hughes wrote:
> > > An other point: have this really to be an addon? The definition of
> > addons is:
> > > "Addons are programs that run for the life time of the device
> > object. ..."
> > > IMO because of this the code should go into a callout and into the
> > tool 
> > > directory in the source tree of HAL instead into a addon.
> > 
> > Yes, I think you are right there. Let me play some more, and I'll send
> > an updated patch.
> > 
> > Thanks for the review.
> 
> New patches attached. I'll patch the spec when we are decided on the key
> names. Please review.

>From a cursory look it seems fine. You need to rename the key
keymap.data so it's clear that we map to Linux key codes. For example
you could call it keymap.data.linux, then again, I suck at naming stuff.

     David




More information about the hal mailing list