dbus/hal local user policy

[Simon McVittie]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Wed, 30 May 2007 at 15:28:24 +0100, Simon Huggins wrote:
> There is now a libpam-foreground in Debian and Ubuntu at least which
> seems to do similar but requires a change to dbus before it'll work with
> at_console.  See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=422349
> Is this the new way now?  Is this ever likely to get into your
> repository?

For what it's worth, I think the patch looks sane, except that it should
probably check for the pam-console-style file too, unless pam-console is
considered obsolete:

(untested)

+  /* check whether the user is at the console according to pam-console */
   result = _dbus_file_exists (_dbus_string_get_const_data (&f));
+  /* failing that, check whether the user is at any console according to
+   * pam-foreground */
+  if (!result)
+    {
+      if (!_dbus_string_append (&f, ":*"))
+        {
+          _DBUS_SET_OOM (error);
+          goto out;
+        }
+
+      if (glob (_dbus_string_get_const_data (&f), 0, NULL, &gl))
+          goto out;
+
+      result = gl.gl_pathc > 0;
+      globfree (&gl);
+    }

As far as I can see, pam-foreground is an Ubuntu'ism which has been
picked up by Debian, and pam-console is a Red Hat thing. Is either of these
likely to become some sort of de-facto standard?

	Simon
- -- 
Simon McVittie, Collabora Ltd.: http://www.collabora.co.uk/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: OpenPGP key: http://www.pseudorandom.co.uk/2003/contact/ or pgp.net

iD8DBQFGXZinWSc8zVUw7HYRAsEXAKCrtfM/7AT7F4XIfqgJSsbc8KRIXwCfdHP0
iDEy1SZv3dSnLHz5mOUmXZs=
=WaeO
-----END PGP SIGNATURE-----