[PATCH] probe-smbios: fix possible inifinite l00p when removing trailing spaces

Guillem Jover guillem.jover at nokia.com
Fri Nov 9 10:50:26 PST 2007


Athough this is not going to happen given current content of the files
parsed, there's the possibility that the loop could never end.
---
 hald/linux/probing/probe-smbios.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

PS: Had to rename the subject as well. Please fix on commit. :)

diff --git a/hald/linux/probing/probe-smbios.c b/hald/linux/probing/probe-smbios.c
index d46daba..2fffd23 100644
--- a/hald/linux/probing/probe-smbios.c
+++ b/hald/linux/probing/probe-smbios.c
@@ -205,7 +205,7 @@ main (int argc, char *argv[])
 	/* read the output of the child */
 	while(fgets (buf, sizeof(buf), f) != NULL)
 	{
-		unsigned int i;
+		int i;
 		unsigned int len;
 		unsigned int tabs = 0;
 
-- 
1.5.3.5



More information about the hal mailing list