[PATCH] libpartutil: dereference pointer after checking it's not NULL

Doug Klima cardoe at gentoo.org
Tue Nov 20 06:33:00 PST 2007


Danny Kukawka wrote:
> On Freitag, 9. November 2007, Guillem Jover wrote:
>   
>> ---
>>  partutil/partutil.c |   24 ++++++++++++++++++------
>>  1 files changed, 18 insertions(+), 6 deletions(-)
>>     
>
> Commited, thanks.
>
> One point: shouldn't there be also a check if pe == NULL after call 
> pe=g_slist_nth_data(...) ? Something like the attached patch.
>
> Danny
>   
Yeah that looks more proper. Checking for NULL before using the pointer++

Good eye Danny.


More information about the hal mailing list