[PATCH] read dmi info from sysfs instead of call dmidecode

Danny Kukawka danny.kukawka at web.de
Mon Nov 26 12:40:29 PST 2007


On Montag, 26. November 2007, Sjoerd Simons wrote:
> On Tue, Nov 20, 2007 at 03:55:39PM +0100, Danny Kukawka wrote:
> > On Dienstag, 20. November 2007, Doug Klima wrote:
> > > Danny Kukawka wrote:
[...]
> > > > Any other comments or okay to commit?
> > >
> > > I like it. I haven't really given the patch much testing since I just
> > > built up a kernel yesterday with the support in it. As long as we have
> > > the fallback to dmidecode, I'm ok with this. Unless we want to bump our
> > > kernel requirement to 2.6.22.
> >
> > Yes, it fallback to hald-probe-smbios if /sys/class/dmi/id is not
> > available. The only ugly thing is
> > osspec_privileged_init_preparse_set_dmi() which we need because some of
> > the sysfs attributes are only readable by root. So we need to parse them
> > before drop privileges.
>
> Why not do the parsing in a callout with root priviledges instead of in hal
> itself ?

Because I would like to eliminate the prober.

Danny



More information about the hal mailing list