[PATCH] Increase polling delay in addon-storage.c

Danny Kukawka danny.kukawka at web.de
Wed Nov 28 15:03:56 PST 2007


On Mittwoch, 28. November 2007, Robby Workman wrote:
> Discussion on IRC about the polling delay centered around the idea
> that optical devices generally take 5 seconds or usually longer to
> be ready for use, and as such a longer wait than 2 seconds is most
> likely desirable.  Two points:
> 1) The choice of 10 seconds is at least partly arbitrary - the
>    individual who brought this up has drives that take 12-13 seconds,
>    while mine takes about 7 seconds.  If some other number is better,
>    then so be it.

Uh, IMO this is at least for linux no good idea.
1) Currently it doesn't matter (IIRC) if the device is ready, if the device 
isn't it get polled again in 2 seconds.
2) this effect also other devices than only CD/DVD devices
3) ... and what's more important: With this change HAL need in the worst case 
10 seconds to detect that the eject button of the device was pressed. This 
would make a big regression to the users. 

I can't see why we should change it to 10 sec. atm.

Danny



More information about the hal mailing list