Acer laptop brightness hal support

Carlos Corbacho cathectic at gmail.com
Fri Sep 7 17:19:18 PDT 2007


Danny Kukawka wrote:
> No, we say: force them to fix the driver to use the prefered sysfs
> backlight interface. If the driver do this it would work without changes
> in the HAL acpi code.

And as the maintainer of acer_acpi, I say: 100% agree. Do _not_ support,
touch or go anywhere near the /proc code - it's a mess, a PITA for me to
support, and as you say - given there's already a perfectly good kernel
backlight subsystem, which acer_acpi is now using, no reason to touch it
either.

> The existing proc support is only there because it was needed in the past,
> but if we add this for the acer_acpi they may never change to use the
> correct way. 

We should already be supporting the correct way. (The /proc interface for
the backlight is left as a convenience only).

> This is the way to force them to do the right and everybody 
> benefit from it.

I agree 100% with this - which is why I added the backlight subsystem code
to acer_acpi in the first place.

To Michal -> If the code is broken, then please continue to discuss this
directly with me - I agree with the HAL maintainers that it is _not_ their
place to try and support the /proc interface when a perfectly good
mechanism already exists to expose the backlight to HAL.

-Carlos
-- 
E-Mail: cathectic at gmail.com
Web: strangeworlds.co.uk
GPG Key ID: 0x23EE722D



More information about the hal mailing list