[PATCH] PolicyKit-gnome: do not depend on polkit-policy-file-validate

David Zeuthen david at fubar.dk
Tue Sep 25 13:27:54 PDT 2007


On Thu, 2007-09-20 at 17:31 +0200, Michael Biebl wrote:
> 2007/9/20, Michael Biebl <mbiebl at gmail.com>:
> > 2007/9/20, Doug Goldstein <cardoe at gentoo.org>:
> 
> > > It's not superfluous since it's actually used in the Makefiles. So now
> > > without this check, if you run "make check", and you don't have the
> > > binary it will bomb for you. While the program is not necessary for
> > > "make && make install", it doesn't mean it's not a dependency.
> > >
> > > The tool is used to validate that the installed files are proper and
> > > functional. Many packagers like to run a package's "make check" step
> > > before building up the package.
> 
> After a quick discussion on IRC, I added an --enable-examples
> configure option, which defaults to off. So the check for
> polkit-policy-file-validate is only done when the examples are built.
> 
> Please review and apply if ok.

Committed with another commit on top that changes the default to on.

Thanks,
David




More information about the hal mailing list