[PATCH] Check if BIOS password is present prior to issuing libsmbios commands

Danny Kukawka danny.kukawka at web.de
Thu Aug 28 02:10:15 PDT 2008


On Donnerstag, 28. August 2008, Richard Hughes wrote:
> On Wed, 2008-08-27 at 21:21 +0200, Danny Kukawka wrote:
> > On Mittwoch, 27. August 2008, Mario Limonciello wrote:
> > > Hello:
> > >
> > > I was made aware of a bug that was present in HAL causing users to get
> > > frequent lockups from their systems when a BIOS password was set.  In
> > > order to work around the issue, I added two patches to libsmbios [1] ,
> > > [2] which is present in the latest libsmbios release (2.0.3) [3].  I
> > > also produced a patch for HAL that uses this added libsmbios support.
> > > These have both been included in both Ubuntu 8.04 and Ubuntu 8.10 [4].
> > > I would like to see them included upstream so that other distributions
> > > can benefit.
> >
> > Thanks, commited to git.
> >
> > I updated configure to check for libsmbios >= v2.0.3 and ifdef'd  the
> > code for the case that the needed version isn't installed to allow using
> > also the old library versions.
>
> I get:
>
> addon-dell-backlight.cpp: In function 'void check_bios_password()':
> addon-dell-backlight.cpp:100: error: 'getPasswordStatus' is not a member of
> 'smi' addon-dell-backlight.cpp:100: error: 'getPasswordStatus' is not a
> member of 'smi'
>
> because:
>
> checking for libsmbios >= 2.0.3... yes
>
> even though I have installed:
>
> libsmbios-devel-2.0.1-2.fc9.1.i386
>
> Maybe the internal version numbers don't correlate with the package
> versions?

Fixed in git:

http://gitweb.freedesktop.org/?p=hal.git;a=commitdiff;h=9e257137b2e699443358b0575cf881c84b75e617

Danny


More information about the hal mailing list