patch to use g_timeout_add_seconds()

Sven Neumann sven at gimp.org
Fri Feb 8 00:05:42 PST 2008


Hi,

On Thu, 2008-02-07 at 22:34 +0100, Danny Kukawka wrote:

> Without any testing: I would't do this:
> 
> +       g_timeout_add_seconds ((ACPI_POLL_INTERVAL * 120),
> +                               battery_poll_infrequently,
> +                               NULL);
> 
> The related code path is possibly CPU and time eating, you don't want have any 
> other timeout synced with this one, since everything other can get 
> delayed/stuck IIRC. At least this code/timer get only called ever hour, this 
> is not that critical.

I have updated the patch to not use g_timeout_add_seconds() here and
also added a comment explaining why. You can find the updated version at
 
 http://sven.gimp.org/misc/hal-timeout-seconds.diff


Sven




More information about the hal mailing list