[PATCH] Add support of the 'mmc.type' parameter

Marcel Holtmann marcel at holtmann.org
Mon Feb 25 11:24:22 PST 2008


Hi Andy,

first of all, it would be nice to have some extra description of what
you patch is doing. Only having a subject is not enough.

> ---
>  doc/spec/hal-spec-properties.xml |    8 ++++++++
>  hald/linux/device.c              |   20 +++++++++++++++-----
>  2 files changed, 23 insertions(+), 5 deletions(-)
> 
> diff --git a/doc/spec/hal-spec-properties.xml b/doc/spec/hal-spec-properties.xml
> index f3e5752..e1e1763 100644
> --- a/doc/spec/hal-spec-properties.xml
> +++ b/doc/spec/hal-spec-properties.xml
> @@ -1833,6 +1833,14 @@ org.freedesktop.Hal.Device.Volume.method_signatures = {'ssas', 'as', 'as'}
>                <entry>Yes</entry>
>                <entry>Firmware revision</entry>
>              </row>
> +            <row>
> +              <entry>
> +                <literal>mmc.type</literal> (int)
> +              </entry>
> +              <entry>example: SDIO</entry>
> +              <entry>Yes</entry>
> +              <entry>Card type</entry>
> +            </row>
>            </tbody>
>          </tgroup>
>        </informaltable>

Second, what do you expect from your patch. The MCC/SD specification has
proper "class" values that identify memory or other IO cards. Can't we
simply use that one instead of SDIO or not.

Regards

Marcel




More information about the hal mailing list