[hal-info PATCH] Rationalise Acer keyboard map

[Danny Kukawka]

On Dienstag, 3. Juni 2008, Daniel Stone wrote:
> On Tue, Jun 03, 2008 at 01:56:51PM +0200, ext Danny Kukawka wrote:
> > I'm not sure if this change is really such a good idea. With this change
> > hal would set keymaps on every single Acer machine, This would mean:
> >
> > 1) set keymaps on Acer machines which need no mapping (e.g. TravelMate
> > 4650 and other), this include the not really needed callout and the
> > 'wrong' entries with keymap data in HAL (incl. memory usage)
> > 2) map more keys (20) than needed on machines which maybe need e.g. only
> > 5 (e.g. a Aspire 1510)
>
> Have you measured the benefits (memory etc) that come from having a
> vastly simplified ruleset?

1) for hald on a HP 2710p (which needs only 3 mappings and has now 11):
1.1) Memory: 33848/4784 (old) vs. 33860/4792 (new fdi-file)
1.2) performance: no significant difference in the startup time of HAL for 
                  both cases (means for me there is no big advantage of 
                  lesser match cases in the file)

2) the startup time differende for a Acer that now has 20 entries, but needs 
   none: 0.742s (20) vs. 0.646 (none) 
   (note: both with valid fdi cache, on an Intel Core2 duo machine)

3) With the new mapping (where more is mapped than needed) the user could get 
confused by entries for keys which not exist.

Danny