[hal-info patch] Some ThinkPad suspend quirks -- ok to commit?

Martin Pitt martin.pitt at ubuntu.com
Wed Jun 18 06:57:28 PDT 2008


Hi all,

I collected some additional ThinkPad quirks from
https://launchpad.net/bugs/199059. 

OK for me to commit those?

Comment 31 [1] is an interesting case:

  system.hardware.product = '2672CBU' (string)
  system.hardware.vendor = 'IBM' (string)
  system.hardware.version = 'Not Available' (string)

On this system, the version name (X31 here) cannot be detected, so the
dpms_quirk is not applied. Applying it unbreaks suspend/resume on that
model. What do we do in this case? Ideally we would add it to 

      <match key="system.hardware.product" prefix_outof="2672;2673;2884;2885">
        <match key="system.hardware.version" contains="X31">
          <merge key="power_management.quirk.dpms_suspend" type="bool">true</merge>

somehow. Thanks for suggestions!

Martin

[1] https://bugs.launchpad.net/ubuntu/+source/hal-info/+bug/199059/comments/31
-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-suspend-quirk-for-yet-another-ThinkPad-X31-model.patch
Type: text/x-diff
Size: 1107 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/hal/attachments/20080618/4e1cb2d2/attachment.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Add-suspend-quirk-for-IBM-A31-product-ID-2652.patch
Type: text/x-diff
Size: 1219 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/hal/attachments/20080618/4e1cb2d2/attachment-0001.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Add-suspend-quirk-for-ThinkPad-X32.patch
Type: text/x-diff
Size: 1228 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/hal/attachments/20080618/4e1cb2d2/attachment-0002.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.freedesktop.org/archives/hal/attachments/20080618/4e1cb2d2/attachment.pgp 


More information about the hal mailing list