hal: Branch 'master' - 3 commits
danny.kukawka at web.de
Mon Mar 3 14:42:11 PST 2008
On Montag, 3. März 2008, David Zeuthen wrote:
> On Mon, 2008-03-03 at 23:23 +0100, Danny Kukawka wrote:
> > - hal_set_proc_title ("hald-addon-storage: no polling because %s is
> > locked via HAL and O_EXCL", device_file); + hal_set_proc_title
> > ("hald-addon-storage: no polling because %s locked via HAL and O_EXCL",
> > device_file);
> I'm not a native speaker but I think removing the "is" is (pun!) wrong.
I'm also not a native speaker but it would fit with this length better in 'ps
aux' output. I'm currently only afraid, that it get to long for ps output and
with that unreadable e.g. on 1024x768 or smaller displays.
> Also, I'm not a big fan of functions returning in the middle; "goto"
> error handling is much more elegant. So please don't change that.
> Anyway, I'm sure a lot of people feel different about this.
I can live with that, also if this would save us one variable we don't need.
More information about the hal