[PATCH] fix hald-addon-dell-backlight AC detection

David Zeuthen david at fubar.dk
Mon Mar 3 16:49:54 PST 2008

On Tue, 2008-03-04 at 01:47 +0100, Danny Kukawka wrote:
> Hi,
> this fixes fd.o bug #13669 and hald-addon-dell-backlight which uses a 
> hardcoded udi to get AC adapter information. With the switch to sysfs 
> power_supply devices for AC adapter the path is no longer valid. I changed 
> the code to check all devices with ac_adapter capability and check then all 
> AC adapter until a device has ac_adapter.present and then get the info about 
> the adapter state from there.
> See attached patch (untested atm, test it tomorrow/later today).

Looks ok to me from a cursory look but please put the declarations at
the start of the function (there's a dbus_error_init() before new
variables). Thanks.


More information about the hal mailing list