[PATCH 6/8] process non-dependant hotplug events in parallel

Patryk Zawadzki patrys at pld-linux.org
Wed Mar 12 13:04:14 PDT 2008


On Wed, Mar 12, 2008 at 8:45 PM, Danny Kukawka <danny.kukawka at web.de> wrote:
> On Freitag, 7. März 2008, Rob Taylor wrote:
>  > +static void
>  > +property_index_check_all (HalDeviceStore *store, HalDevice *device,
>  > gboolean added)
>  > +{
>  > +     GList *indexed_properties, *lp;
>  > +
>  > +     indexed_properties = g_hash_table_get_keys (store->property_index);
>  > +     for (lp = indexed_properties; lp; lp = g_list_next (lp)) {
>  > +             if (hal_device_property_get_type (device, lp->data) ==
>  > HAL_PROPERTY_TYPE_STRING) {
>  > +                     property_index_modify_string (store, device, lp->data, added);
>  > +             }
>  > +     }
>  > +}
>
>  Hm, overseen something:
>
>  This would need at least glib >= 2.14 since g_hash_table_get_keys () was added
>  in this version. Not sure atm if we want to depend on this version atm since
>  it was branched 2007-11-07.

Should that be a problem it would probably be a good idea to ask the
adopters. If a distro depends on a half year old version of glib (no
major API breakage introduced by an upgrade) it's possible it will
stick with whatever version of HAL it currently ships. Within the next
month most major distros will have to move to glib 2.16 anyway because
of GNOME dependencies.

-- 
Patryk Zawadzki
PLD Linux Distribution


More information about the hal mailing list