[PATCH 3/4] hal-info: Clean up keymap-check.sh

Daniel Stone daniel.stone at nokia.com
Tue Mar 25 01:07:54 PDT 2008


On Mon, Mar 24, 2008 at 08:08:21PM -0700, ext Victor Lowther wrote:
> -	sed -ne '/<append key="input.keymap.data"/ { # only keymap data lines
> +	sed -ne '/^[[:blank:]]*<append key="input.keymap.data"/ { # data lines

Pretty sure [[:blank:]] is a GNUism.

> -		isin $data && echo "$data "
> +		grep -q "^${data}\$" /tmp/quirk-keymap-list.txt || echo "$data "

Pretty sure extended mode without invoking egrep is a GNUism.

> -		if [ ! -z "$ret" ]; then
> +		if [ "$ret" ]; then

This is a bashism, use -n instead or ! [ -z "$ret" ].

Cheers,
Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.freedesktop.org/archives/hal/attachments/20080325/d522cebc/attachment.pgp 


More information about the hal mailing list