[PATCH] remove use of at_console in the D-Bus configuration file
danny.kukawka at web.de
Thu Mar 27 11:01:21 PDT 2008
On Donnerstag, 27. März 2008, David Zeuthen wrote:
> On Wed, 2008-03-26 at 14:46 +0100, Danny Kukawka wrote:
> > On Mittwoch, 26. März 2008, David Zeuthen wrote:
> > > Hey Danny,
> > >
> > > We should probably get this simple patch in. Am checking with you since
> > > you're driving the release train for .11. The main reason for this
> > > patch is that PolicyKit is used _anyway_ to control access to methods.
> > > And using pam_console to do this breaks when you try to e.g. run a
> > > power manager on the login screen as we're doing in Fedora 9 with g-p-m
> > > and the new gdm.
> > >
> > > (and this is something I expect a lot of other distros will do for at
> > > least GNOME 2.24 which is less than six months out.)
> > >
> > > OK to commit?
> > Isn't there a way to change the .in file to get it also work if there is
> > no PolicyKit? I have atm no idea if someone really do this or not, but
> > would be IMO nice to get a different hal.conf if you compiled hal to use
> > PolicyKit than in the case you compiled it without PolicyKot/ConsoleKit.
> I'll add a warning to configure.in to instruct people to add whatever
> they need. I want to avoid, for reasons mentioned by Martin, shipping
> a .conf file that uses RH-specific constructs like "at_console".
I know what the goal of your change is, but I thought it would be nice to
handle both cases.
Go ahead and commit to HEAD and the branch.
More information about the hal