[PATCH] hal probe modem caps ondemand

[Vitja Makarov]

2008/5/6 Alex Kanavin <ak at sensi.org>:
> 2008/5/4 Vitja Makarov <vitja.makarov at gmail.com>:
>
> > Probe CDC-ACM modems, found in most cell phones on the fly, using
>  >  AT+GCAP modem command.
>  >  I tested it with 1 Nokia GSM phone, and 2 CDMA.
>
>  In practice most if not all phones seem to use protocol 1 (generic
>  v.25) in their usb interface descriptions and require probing, but it
>  wouldn't hurt to list the other protocols as well. Otherwise, the
>  patch seems fine to me (if the coding style is ok - someone else
>  should review that). A much simpler patch for just tagging interface
>  class 2/subclass 2 devices as modems has just been committed, so you
>  should redo your patch against that.
>
>  --
>  Alexander
>

I'm wondering what for are CDMA, 3G, GSM subclasses.

Here is new version of patch.
It simply calls prober for V.250 CDC-ACM modems.
Also I don't understand why we don't check interface.class and only
test interface.subclass?

and some prober fixes, I'm not sure it should lay in
hald/linux/probing as it's actually callout,
but can be used as prober too.


vitja.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: hal-info-modem-cdc-acm.patch
Type: text/x-diff
Size: 585 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/hal/attachments/20080506/c8af87ad/attachment-0002.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: hal-probe-modem.patch
Type: text/x-diff
Size: 5050 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/hal/attachments/20080506/c8af87ad/attachment-0003.patch