[PATCH 1/6] use embedded input_local.h instead of system linux/input.h

Michael Biebl mbiebl at gmail.com
Sun Nov 2 16:40:49 PST 2008


2008/11/2 Matthew Garrett <mjg59 at srcf.ucam.org>:
> On Sat, Nov 01, 2008 at 11:28:50AM +0100, Danny Kukawka wrote:
>
>> It would be better to add some ifdefs instead of copy always stuff from the
>> latest kernel version (it also extend the package size and the maintenance
>> effort). IMO the input.h should always be from the system HAL gets compiled
>> on and not from a maybe several versions newer kernel, which isn't installed
>> in the system.
>
> That means having to rebuild hal every time you upgrade the kernel
> headers (and kernel) if you want to get the full set of events. I think
> carrying an internal copy is a sensible choice here.
>

I don't understand your logic.

Say there is a new kernel release with new events.
Then we'd have also have to update our local input.h, make a release
and recompile.

That is even more work, then a simple recompile.

Michael


-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?


More information about the hal mailing list