[PATCH 0/4] Cleanup hald test scripts

[Gilles Dartiguelongue]

Le mardi 04 novembre 2008 à 00:15 +0200, Guillem Jover a écrit :
> Actually, disregard this previous patch, here follows some patches to
> cleanup *all* the testing scripts.

did you tested those patch with another shell than bash ? (say dash, ash
or busybox's shell) iirc function declaration is bash specific.

According to coreutils-6.12 manpages, mktemp templates are deprecated.
You can always suffix the value it returns if you want to make it a bit
more visible to the user what this directory is for.

> Guillem Jover (4):
>   move common test setup code to setup-hald.sh
>   allow running hald for testing without hal-info
>   use mktemp instead of a fixed directory
>   setup-hald.sh: cleanup after ourselves
> 
>  hald/debug-hald.sh    |   32 +-------------------------------
>  hald/massif-hald.sh   |   13 +------------
>  hald/run-hald.sh      |   32 +-------------------------------
>  hald/setup-hald.sh    |   41 +++++++++++++++++++++++++++++++++++++++++
>  hald/valgrind-hald.sh |   32 +-------------------------------
>  5 files changed, 45 insertions(+), 105 deletions(-)
>  create mode 100644 hald/setup-hald.sh
> 
> regards,
> guillem
> 
-- 
Gilles Dartiguelongue <gilles.dartiguelongue at esiee.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Ceci est une partie de message
	=?ISO-8859-1?Q?num=E9riquement?= =?ISO-8859-1?Q?_sign=E9e?=
Url : http://lists.freedesktop.org/archives/hal/attachments/20081105/2d7004cc/attachment.pgp