[patch] fix segfault when rfkill device does not have type

Kay Sievers kay.sievers at vrfy.org
Thu Oct 9 00:29:45 PDT 2008


On Thu, Oct 9, 2008 at 9:23 AM, Danny Kukawka <danny.kukawka at web.de> wrote:
> On Mittwoch, 8. Oktober 2008, Dan Williams wrote:
>> On Wed, 2008-10-08 at 20:58 +0100, Richard Hughes wrote:
>> > Attached patch fixes a crash when the rfkill device does not have a
>> > type. Backtrace is at https://bugzilla.redhat.com/show_bug.cgi?id=466150
>> >
>> > I've committed this.
>>
>> Do we have any idea what drivers cause this, and if so, can we bash
>> those drivers with a cluebat?  Shouldn't ever happen if the drivers
>> don't suck of course and HAL needs not to crash here, but we should also
>> fix stuff upstream.
>
> Also from the backtrace it looks like a buggy driver. The sysfs path looks
> strange too: /sys/rfkill0 . Shouldn't it be something
> like /sys/class/rfkill/rfkill0 ?

Yeah, that looks like a broken driver/kernel:
  "ACTION=change\000DEVPATH=/rfkill0\000SUBSYSTEM=rfkill\000"

It must be some directory in "/sys/devices/ ... /rfkill0" and
/sys/class/rfkill/rfkill0 a symlink pointing to that directory.

Kay


More information about the hal mailing list