volume label parsing regression

Martin Pitt martin.pitt at ubuntu.com
Fri Apr 3 07:51:23 PDT 2009


Hello all,

https://launchpad.net/bugs/347370 reported a regression in volume
labels in hal. Spaces are now mangled to '_'.

I tracked this down to 79b92dbdf65b8c978d5a8f6fb2b421aac83c3de3 and
committed a fix:

  Not probing volumes ourselves and reading from the udev db (commit
  79b92dbdf65b8c978d5a8f6fb2b421aac83c3de3) caused a regression:
  udevadm info's ID_FS_LABEL is mangled, e. g. spaces appear as '_'.
  Use ID_FS_LABEL_ENC instead and use a new hal/util.c function
  hal_util_decode_escape() to decode those. 

  http://cgit.freedesktop.org/hal/commit/?id=97b023f94f1d79a19bc0489c0d167bdaebb765fd

It works well for me, but I always appreciate a second pair of eyes.

Thank you!

Martin
-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
Url : http://lists.freedesktop.org/archives/hal/attachments/20090403/61f36c90/attachment.pgp 


More information about the hal mailing list