[PATCH] removes useless 30-keymap-module-thinkpad-acpi.fdi

[Sébastien Mazy]

On Mon, Feb 02, 2009 at 02:22:52PM +0100, Danny Kukawka wrote:
> On Donnerstag, 22. Januar 2009, Sébastien Mazy wrote:
> > On Thu, Jan 15, 2009 at 01:11:25PM +0100, Sébastien Mazy wrote:
> > > This patch removes the file 30-keymap-module-thinkpad-acpi.fdi from
> > > hal-info because:
> > >  - the linux kernel module thinkpad_acpi already sends relevant keycodes
> 
> Since which kernel version?

The commit is dated 19 Jul 2007: 
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=edf0e0e56904f794c97ca6c4562d8256e3d8d8e3

This was released in 2.6.23 (2007-10-09).

> > >  - it remapped KEY_WLAN to KEY_RADIO, which is unwanted
> 
> Why is it KEY_WLAN? If this is 'Fn+F5', the 'Setup Guide' for e.g. a T61 says 
> it's the key for 'Manage wireless connections' (which should be KEY_RADIO if 
> it handles e.g. also bluetooth or wwan) while there is also a 'Wireless radio 
> switch' (which should be KEY_WLAN).

Here is the reason given by Henrique de Moraes Holschuh on the
linux-thinkapd ML:

On Mon, Oct 20, 2008 at 04:37:37PM -0200, Henrique de Moraes Holschuh wrote:
> It is debatable whether it should be issuing KEY_BLUETOOTH instead of
> KEY_WLAN, but the deal there is that ThinkVantage doesn't use it as a simple
> bluetooth toggle.  I wanted a KEY_<any data radio>, but there is no such
> thing (KEY_RADIO is for stuff like a tunner/radio/cd/aux selector in a
> remote control).

BTW, he is CC'ed in case I wrote something inexact.

-- 
Sébastien Mazy