[PATCH] removes useless 30-keymap-module-thinkpad-acpi.fdi

[Sébastien Mazy]

On Mon, Feb 02, 2009 at 06:34:16PM +0100, Danny Kukawka wrote:
> On Montag, 2. Februar 2009, Sébastien Mazy wrote:
> > On Mon, Feb 02, 2009 at 02:22:52PM +0100, Danny Kukawka wrote:
> > > Why is it KEY_WLAN? If this is 'Fn+F5', the 'Setup Guide' for e.g. a T61
> > > says it's the key for 'Manage wireless connections' (which should be
> > > KEY_RADIO if it handles e.g. also bluetooth or wwan) while there is also
> > > a 'Wireless radio switch' (which should be KEY_WLAN).
> >
> > Here is the reason given by Henrique de Moraes Holschuh on the
> > linux-thinkapd ML:
> >
> > On Mon, Oct 20, 2008 at 04:37:37PM -0200, Henrique de Moraes Holschuh wrote:
> > > It is debatable whether it should be issuing KEY_BLUETOOTH instead of
> > > KEY_WLAN, but the deal there is that ThinkVantage doesn't use it as a
> > > simple bluetooth toggle.  I wanted a KEY_<any data radio>, but there is
> > > no such thing (KEY_RADIO is for stuff like a tunner/radio/cd/aux selector
> > > in a remote control).
> 
> Then we should add such a key (e.g. KEY_RFKILL_ALL like SW_RFKILL_ALL, 247 is 
> still unused as it looks to me) to the kernel, since there have to be a way 
> to handle WLAN/WWAN/Bluetooth via one key as under other OS.


Valid point but that's another issue IMHO. It doesn't justify the need
for 30-keymap-module-thinkpad-acpi.fdi.

Even worse, if such a key was added to the kernel and thinkpad-acpi, it
would be hidden to userspace because HAL would still "fix" and remap the
scancode...


-- 
Sébastien Mazy